feat: Remove setting the default endpoint in StubSettings #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removing setting the default endpoint maybe breaking for customers, especially for some handwritten libraries like Bigtable, can you please verify? If yes, I don't think we want to change it until |
product-auto-label
bot
added
size: l
lqiu96
force-pushed
the
remove-setting-getDefaultEndpoint
branch
from
c826fe6
to
fd024d5
Compare
|
|
blakeli0
approved these changes
Jan 9, 2024
lqiu96
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do
{serviceName}.googleapis.com.getEndpoint()will return the user set endpoint. If the user does not set an endpoint, the method will return the endpoint set by the service.Showcase
Showcase Clients do not have a valid serviceName and cannot construct an endpoint via the EndpointContext without an explicit endpoint input. To run these locally, we must configure the endpoint explicitly to point to
localhost:7469for gRPC andhttp://localhost:7469for httpjson.Google Cloud Libraries
For Google Cloud client libraries, the service name is stored in the EndpointContext and parsed from the proto or service yaml file.
BEGIN_COMMIT_OVERRIDE
feat: Do not set the default endpoint in StubSettings
feat: StubSettings'
getEndpoint()will return the service's pre-configured endpoint if there are no user configurationsEND_COMMIT_OVERRIDE